TropicalGeometry: fix tropical_variety_prime_singular #5397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added function to make variable names singular compatible. fixes oscar-system#5392
YueRen
added
topic: tropical geometry
release notes: not needed
fieker
reviewed
Oct 1, 2025
Contributor
|
apart from this working, this is still a cludge |
Member
|
Can you add the example from the issue as a testcase? |
Member
Author
Is done! |
lgoettgens
reviewed
Oct 2, 2025
Co-authored-by: Lars Göttgens <[email protected]>
removed the conversion of Oscar ideal to Singular via string
Member
Author
|
I've now replaced the original dirty hack with the suggestion by @fingolfin. No conversion of an OSCAR ideal to a Singular string necessary anymore, but the need to call the Singular interpreter and the conversion of a Singular fan string to an OSCAR polyhedral complex remain. |
fingolfin
reviewed
Oct 14, 2025
fingolfin
reviewed
Oct 14, 2025
fingolfin
reviewed
Oct 14, 2025
YueRen
force-pushed
the
yr/tropicalVarietySingular
branch
from
4f3baaa to
032aae9
Compare
fingolfin
reviewed
Oct 14, 2025
Member
Author
|
@fingolfin Everything should be using |
Member
|
Thanks @YueRen this looks good. Unfortunately it seems to cause a crash :-( in CI, in the doctests: |
VictoriaSchleis
approved these changes
Oct 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5397 +/- ##
==========================================
- Coverage 84.20% 77.98% -6.23%
==========================================
Files 717 731 +14
Lines 97992 103333 +5341
==========================================
- Hits 82519 80589 -1930
- Misses 15473 22744 +7271
🚀 New features to boost your workflow:
|
fingolfin
reviewed
Nov 6, 2025
Member
|
The crash is in a doctest in julia> K,t = rational_function_field(GF(101),:t);
julia> R,(x,y,z) = K["x","y","z"];
julia> nu_2 = tropical_semiring_map(QQ,2)
Map into Min tropical semiring encoding the 2-adic valuation on Rational field
julia> f1 = 8*x^2 + x*y + x*z + x + 8*y^2 + y*z + y + 8*z^2 + z + 8;
julia> f2 = x + 2;
julia> I = ideal([f1,f2]);
julia> TropI_2 = tropical_variety(I,nu_2; skip_saturation=true, skip_decomposition=true)
[76002] signal 11 (2): Segmentation fault: 11
in expression starting at REPL[13]:1
unknown function (ip: 0x0) at (unknown file)
Allocations: 99607851 (Pool: 99573602; Big: 34249); GC: 34
/Users/mhorn/.local/bin/j12: line 2: 76002 Segmentation fault: 11 julia +1.12 --proj=p/1.12 "$@"Debugger backtrace: Perhaps @hannes14 or @YueRen can make something out of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added function to make variable names singular compatible. fixes #5392